Skip to content

feat: Group one audit tests #9445

Merged
vezenovm merged 25 commits intomasterfrom
group-1-audit
Aug 27, 2025
Merged

feat: Group one audit tests #9445
vezenovm merged 25 commits intomasterfrom
group-1-audit

Conversation

@vezenovm
Copy link
Copy Markdown
Contributor

@vezenovm vezenovm commented Aug 8, 2025

Description

Problem*

Just a shared branch for additional tests, debugging, or changes needed for the first internal audit.

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: bb7410c Previous: ec24082 Ratio
test_report_zkpassport_noir_rsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 45c0151 Previous: e54057d Ratio
private-kernel-tail 1.778 s 1.344 s 1.32

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 9fe0a76 Previous: cc0c20d Ratio
private-kernel-inner 0.018 s 0.014 s 1.29

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 14, 2025

Changes to Brillig bytecode sizes

Generated at commit: c6ec4b460a0463e9e1e8df8e479fd3dd3abec0e2, compared to commit: cc0c20d4840a00025330a0b3420dd854544ac681

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
references_inliner_max +53 ❌ +63.86%
references_inliner_zero +67 ❌ +45.27%

Full diff report 👇
Program Brillig opcodes (+/-) %
references_inliner_max 136 (+53) +63.86%
references_inliner_zero 215 (+67) +45.27%
references_inliner_min 286 (+59) +25.99%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 14, 2025

Changes to number of Brillig opcodes executed

Generated at commit: c6ec4b460a0463e9e1e8df8e479fd3dd3abec0e2, compared to commit: cc0c20d4840a00025330a0b3420dd854544ac681

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
references_inliner_zero +78 ❌ +31.45%
references_inliner_max +33 ❌ +21.85%

Full diff report 👇
Program Brillig opcodes (+/-) %
references_inliner_zero 326 (+78) +31.45%
references_inliner_max 184 (+33) +21.85%
references_inliner_min 457 (+74) +19.32%

@vezenovm vezenovm marked this pull request as ready for review August 18, 2025 15:54
@vezenovm vezenovm requested a review from a team August 18, 2025 15:54
@vezenovm
Copy link
Copy Markdown
Contributor Author

We may as well get in this PR and #9425

Copy link
Copy Markdown
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread compiler/noirc_evaluator/src/ssa/opt/pure.rs Outdated
Comment thread compiler/noirc_evaluator/src/ssa/opt/pure.rs Outdated
@vezenovm vezenovm enabled auto-merge August 26, 2025 19:48
@vezenovm vezenovm added this pull request to the merge queue Aug 27, 2025
Merged via the queue into master with commit f601afe Aug 27, 2025
122 checks passed
@vezenovm vezenovm deleted the group-1-audit branch August 27, 2025 16:40
github-merge-queue Bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Aug 28, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: make Ord for slices lexicographic (elements first, then length)
(noir-lang/noir#9555)
chore(ssa): Refactor `unrolling`
(noir-lang/noir#9653)
chore(docs): Update dependency page's examples
(noir-lang/noir#9634)
fix(ssa): Constant fold Brillig calls using the SSA interpreter
(noir-lang/noir#9655)
chore: LICM refactors (noir-lang/noir#9642)
chore: add test for trait bound on implementing type
(noir-lang/noir#9652)
chore: pass `DataFlowGraph` instead of `Function` as arg
(noir-lang/noir#9656)
feat: Group one audit tests
(noir-lang/noir#9445)
fix(expand): better handling of dereferences (again)
(noir-lang/noir#9654)
feat(mem2reg): address last known value is independent of its aliases
(take three) (noir-lang/noir#9633)
chore: remove handling for slice arguments to MSM
(noir-lang/noir#9648)
fix: validate binary operations which do not allow fields
(noir-lang/noir#9649)
END_COMMIT_OVERRIDE
github-merge-queue Bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Aug 28, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: make Ord for slices lexicographic (elements first, then length)
(noir-lang/noir#9555)
chore(ssa): Refactor `unrolling`
(noir-lang/noir#9653)
chore(docs): Update dependency page's examples
(noir-lang/noir#9634)
fix(ssa): Constant fold Brillig calls using the SSA interpreter
(noir-lang/noir#9655)
chore: LICM refactors (noir-lang/noir#9642)
chore: add test for trait bound on implementing type
(noir-lang/noir#9652)
chore: pass `DataFlowGraph` instead of `Function` as arg
(noir-lang/noir#9656)
feat: Group one audit tests
(noir-lang/noir#9445)
fix(expand): better handling of dereferences (again)
(noir-lang/noir#9654)
feat(mem2reg): address last known value is independent of its aliases
(take three) (noir-lang/noir#9633)
chore: remove handling for slice arguments to MSM
(noir-lang/noir#9648)
fix: validate binary operations which do not allow fields
(noir-lang/noir#9649)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants